Skip to content

[firebase_auth_web] Fix firebase auth test by wrapping Dart functions in js.allowInterop #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

chingjun
Copy link
Contributor

Description

Fix firebase auth test by wrapping Dart functions in js.allowInterop
And also fix the Promise.then mock. The JS version of Promise.then takes
two parameters.

Dart functions need to be wrapped in js.allowInterop to be called from
JavaScript. The current test is failing on dart2js.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

And also fix the Promise.then mock. The JS version of Promise.then takes
two parameters.

Dart functions need to be wrapped in js.allowInterop to be called from
JavaScript. The current test is failing on dart2js.
@chingjun chingjun changed the title [firebase_auth] Fix firebase auth test by wrapping Dart functions in js.allowInterop [firebase_auth_web] Fix firebase auth test by wrapping Dart functions in js.allowInterop Jan 13, 2020
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version in the pubspec.yaml, and document the change in the CHANGELOG.md.

@chingjun
Copy link
Contributor Author

pubspec and changelog updated. Thanks!

@ditman ditman merged commit e82ad5d into firebase:master Jan 14, 2020
@firebase firebase locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants